Oh, I didn't know just clicking the link works in the preview pane. I thought I should always use Ctrl+Click.
So what I meant by the "fix" is actually about clicking the link in the preview pane. Before my PR I couldn't click the link because data-href was not set properly.
Clicking a link in Preview works. But Ctrl-clicking in the code / Markdown doesn't open the linked note. But maybe I am missing something? (sorry haven't read all the new posts (carefully))
Looks good. Will you add this to the Open VSX Registry (https://open-vsx.org/) so it can be used with other editors that support VSCode's extension API?
I'm not sure if it's worth it (adds some maintenance costs), I'll start a poll later, but you can post it above if you wish, I see that Markdown All in One has been officially posted over.
I am able to get the file listing of Joplin that is running on another computer if I do port forwarding. It kind of works but it opens the notes in an external editor on the other computer, not on the one that is running VsCode
Apologies for the dumb question. I use VSCode to run some scripts from a particular project folder, so I've got that folder and several scripts open all day. Would I need a separate instance of VSCode to use it to edit Joplin notes via this plugin?
Kind of a related question, instead of using the plugin, can I use VSCode as Joplin's external editor, meaning when I click on external edit button, the note opens in VSC?
Just tested the release 0.7.2. The note title in the tab is really useful
For my use case it would be nice to have the note title as header at start of the note, too. It would look better and make the linter happy. For example:
# Note title
## Actual note content starts here
some more content
I don't know whether others want it like this. Maybe an option like "Add note title as header" would be suited.
@rxliuli: Do you think it's possible to implement it?
Of course, the main reason I didn't want to deal with it was that I didn't want to parse markdown, but I'll try to just split the string and get the first line to do it
We have function (in markdownUtils I think) to do that. The tricky part is to strip off markup and take into account that this line can contain html or an image for example.
Also, after I tried markdownUtils.titleFromBody, I decided not to use it, seems inconsistent with the existing behavior of opening in an external editor, it also removes the # in the title @laurent