Do I need to re-request a review of a pull-request once it is fixed?


I've recently added a pull-requst for moving the themes out into their own files, and Laruent has reviewed it twice. I have fixed the changes he requested, and I just want to ask since it's the first time I'm doing a pull-request, do I need to press the "re-request review" button for a notification to appear, or is one created when I press the "resolve comment"?

I'm only wondering since I'm not sure if it shows up as "resolved" for the reviewer or if I need to tell them, and I don't want to stress about it! That's why I'm asking here before, so I don't press the button and the reason there is no more answer is lack of time at the moment. :slight_smile:

1 Like

Have a link to the PR in question? Thanks

Sorry... I wanted to add that but forgot: Moved all themes out into their own .js theme files by TobiasDev · Pull Request #2951 · laurent22/joplin · GitHub

There is the link. :slight_smile:

1 Like

Reading Laurent’s feedback there, I’d wait a bit still. The team here is in the middle of GSoC, I know that the devs are getting new features implemented (look at the WYSIWYG Editor), and with the world events going on, I know my personal schedule is a bit more out of whack than normal.

Everything here comes when it does on a mostly volunteer basis. If no one gets back to you within the next couple days or so, then request a review again

Cool! That is just what I wanted to know. :slight_smile: Because I wasn't sure if he "automatically" got a notification.

Just between you and me (and every other living soul reading here), he sometimes seems to forget that emails and notifications exist. :rofl: