Regression: wrap selected text with backticks

[jyanko]

Operating system

macOS

Joplin version

3.1.23

Desktop version info

Joplin 3.1.23 (prod, darwin)

Client ID: 1e007f11508741f0ac2b509690f52084
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Revision: b3ea127

Backup: 1.4.2
Jira Issue: 2.1.0
Menu items, Shortcuts, Toolbar icons: 1.1.0
Note overview: 1.5.4
Search & Replace: 2.2.0
Templates: 2.2.0

Editor

Markdown Editor

What issue do you have?

Somewhere along the way, the functionality to balance/wrap backticks on selected text stopped working. Not sure exactly which version this happened in, but somewhere betweeen v3.0.15 and v3.1.23

Losing this his has been very noticable to me as I'd built a muscle memory for selecting a string of text to format as code in my daily journeys, but this suddenly stopped working.

Expected behaviour:

1. select string of text (ie: bob)
2. press character type to wrap start and end of string with (ie: quote, backtick, etc)
3. string is now wrapped in the character type (ie: `bob` or "bob" or [bob] )

Actual behaviour:

1. select string of text (ie: bob)
2. press backtick character to wrap sting in backticks
3. selected string is removed and replaced with a single backtick

I've taken the time to check this out in both versions v3.0.15 and v3.1.23 and it seems the functionality still works for wrapping other quotes and brackets, but seems to have stopped working specfically for the backticks.

v3.0.15	v3.1.23	format	character
PASS	PASS	wrap with: { }	open curly brace
PASS	PASS	wrap with: ( )	open parenthesis
PASS	PASS	wrap with:	open square bracket
PASS	FAIL	wrap with: ` `	backtick
PASS	PASS	wrap with: " "	double quote
PASS	PASS	wrap with: ' '	single quote

This is somewhat related to an older post which discussed this selection wrapping

Surround selected text with Emphasis

At the moment it’s possible to surround (in the editor) the selected text with parenthesis or quotes by selecting part of the text and pressing one of the following characters ( [ " or '. For example in a sentence Feature requests and support one can select the word requests and press ( which results surrounding this word with parenthesis: Feature (requests) and support It’s extremely useful because it speeds up editing notes. Why not to extend the supported types of surrounding to the foll…

[personalizedrefriger]

Thank you for reporting this! I'm linking to the relevant GitHub issue.

Issue cause: The issue was caused by a misconfiguration after the upgrade from CodeMirror 5 to CodeMirror 6 — the set of auto-pairing braces wasn't specified correctly.

Workaround: It's possible to continue using the CodeMirror 5 version of the editor. To do this, in settings > general > advanced, check "use the legacy Markdown editor".

[jyanko]

Excellent.
Thanks for the pointer to using the legacy editor.
That gets it working for me again in v3.1.23 - so that workaround should be ok for the time being

[jyanko]

Following up...

Just checked with v3.1.24 - and the auto-wrapping is now working for backticks w/o needing to enable the legacy editor.

Nice to see such a rapid fix for this