vwal
11 August 2024 11:28
1
macOS
3.1.1
Joplin 3.1.1 (prod, darwin)
Client ID: 0936eceabaa4460b9b06c4c96713dff5
Revision: a97c04c
Backup: 1.4.2
Joplin Cloud
Markdown Editor
I just installed 3.1.1 and have two issues with its operation:
"Find in page" doesn't work while the markdown editor is not open. Has it been moved someplace or removed? It is a feature that I use all the time, especially on longer pages. Needing to switch to the markdown view to search isn't the best because the whole point of the view mode is to read a page in the non-editable "presentation" format.
Auto-close-backtick no longer works in the markdown editor. I.e., when typing a `, the corresponding closing ` is not automatically added. Similarly, if I select a word or number of words is now replaced by a backtick rather than wrapped in backticks when the backtick is pressed.
Otherwise, the new markdown mode layout is an improvement, especially on the mobile devices where it now has a consistent look.
muzak
11 August 2024 22:44
3
3.1.1 defaults to the beta Markdown editor, which currently has a Markdown editor-only Find panel.
If you require the old Find bar that works in both editor and viewer, click Tools > Options (Ctrl+Comma ) > General > Show Advanced Settings > check Use the legacy Markdown editor.
I can reproduce both backtick issues.
vwal
12 August 2024 21:20
4
Having the find feature in the presentation view is pretty important.. not having the find feature there makes the presentation view easily pointless, especially when viewing technical materials. Hopefully, these items will be addressed in a future version. Until then, the legacy markdown editor does the job.
vwal:
"Find in page" doesn't work while the markdown editor is not open. Has it been moved someplace or removed? It is a feature that I use all the time, especially on longer pages. Needing to switch to the markdown view to search isn't the best because the whole point of the view mode is to read a page in the non-editable "presentation" format.
I'm linking to a related pull request:
laurent22:dev ← personalizedrefrigerator:pr/desktop/connect-cm6-search-to-joplin-search
opened 12:07AM - 13 Aug 24 UTC
# Summary
This pull request fixes a Markdown editor [issue originally reporte… d on the Joplin forum](https://discourse.joplinapp.org/t/search-and-auto-quote/39590) — it was impossible to search a note when the note editor pane was hidden.
# Remaining issues
- It's possible for the Markdown viewer's search panel to be visible in the Rich Text editor. **This is also an issue with the legacy editor prior to this pull request**. To see this:
1. Open the markdown editor.
2. Hide the editor such that just the viewer is visible.
3. Press <kbd>ctrl</kbd>-<kbd>f</kbd> such that the search bar is visible.
4. Switch to the Rich Text Editor.
# Screen recording
[Screen recording: Searching in the note viewer, then switching to read-only mode.](https://github.com/user-attachments/assets/dfa72b74-6768-4029-b63b-e42f722ac44b)
# Testing plan
**Automated test**: A new Playwright test has been added that verifies:
- It's possible to search (local search) in the new markdown editor.
- The search input remains visible after switching layouts such that the editor is hidden.
- Changing the search in the markdown editor changes the matches in the viewer.
- Changing the search when only the viewer is visible changes the highlighted matches.
**Manual testing (Ubuntu 24.04)**:
1. Create a note containing several instances of the word "test".
6. Search globally for `test`.
7. Open the note created in `1` from the note list.
8. Open local search (<kbd>ctrl</kbd>-<kbd>f</kbd>).
9. Verify that the local search query matches the global search query.
10. Change the local search query. Verify that only the new matches are highlighted in both the viewer and editor.
11. Close the local search panel.
12. Verify that at least one copy of the original global search is highlighted in the viewer.
13. Verify that all copies of the original global search are highlighted in the editor.
**Regression testing: Mobile/web (Firefox)**:
1. Create an empty note with `test... Test.` as its content.
14. Press <kbd>ctrl</kbd>-<kbd>f</kbd>
15. Verify that the search panel is visible.
16. Search for `test`.
17. Click "next".
18. Verify that the selection moves to the next match.
19. Open the advanced search options.
20. Type "testing" in the "replace" input.
21. Click "replace".
22. Verify that the selected match has been replaced with "testing".
23. Click "replace all".
24. Verify that both matches have been replaced.
25. Click '.*' (regex)
26. Replace the text in the find input with `t.*`.
27. Verify that all content is highlighted.
28. Close the search menu by clicking the "x" button.
29. Show the search menu by clicking the "🔍" button.
30. Click on the note editor and press <kbd>ctrl</kbd>-<kbd>f</kbd>.
31. Verify that the search menu is no longer visible.
<!--
Please prefix the title with the platform you are targetting:
Here are some examples of good titles:
- Desktop: Resolves #123: Added new setting to change font
- Mobile, Desktop: Fixes #456: Fixed config screen error
- All: Resolves #777: Made synchronisation faster
And here's an explanation of the title format:
- "Desktop" for the Windows/macOS/Linux app (Electron app)
- "Mobile" for the mobile app (or "Android" / "iOS" if the pull request only applies to one of the mobile platforms)
- "CLI" for the CLI app
If it's two platforms, separate them with commas - "Desktop, Mobile" or if it's for all platforms, prefix with "All".
If it's not related to any platform (such as a translation, change to the documentation, etc.), simply don't add a platform.
Then please append the issue that you've addressed or fixed. Use "Resolves #123" for new features or improvements and "Fixes #123" for bug fixes.
AND PLEASE READ THE GUIDE: https://github.com/laurent22/joplin/blob/dev/readme/dev/index.md
-->
1 Like
system
12 September 2024 04:54
6
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.