PDF viewer broken?

LeeBreisacher · 16 August 2024 05:05

Operating system

Windows

Joplin version

3.1.1

Desktop version info

Joplin 3.1.1 (prod, win32)

Client ID: 20ee7ddfafe148fbb49548a412501d20
Sync Version: 3
Profile Version: 47
Keychain Supported: Yes

Revision: a97c04c

Favorites: 1.3.2
Hotfolder: 1.2.0
Note list (Preview): 1.1.0

Editor

Rich Text Editor

What issue do you have?

The in-note PDF Viewer seems to be not working. I'm pretty sure it was fine a few days ago. I did install 3.1.1 recently.

personalizedrefriger · 16 August 2024 05:25

Thank you for reporting this! I can reproduce this on a Windows 11 VM.

In particular, this seems related to the format of Windows paths (C:\...) and this change that moved the note viewer to a separate process. I'm working on fixing this!

personalizedrefriger · 16 August 2024 09:49

This should be fixed by the following pull request:

github.com/laurent22/joplin

Desktop: Windows: Fix PDF and other media rendering

laurent22:dev ← personalizedrefrigerator:pr/desktop/fix-windows-media-rendering

opened 09:48AM - 16 Aug 24 UTC

personalizedrefrigerator

+184 -16

# Summary This pull request fixes a two Windows note viewer regressions: - *…*The PDF viewer failed to load on Windows**: This was [originally reported on the forum](https://discourse.joplinapp.org/t/pdf-viewer-broken/39658). - This is a regression from https://github.com/laurent22/joplin/commit/d2028588e8c4a70caf0940426ab0fcd271ea2bcd and seems related to Windows paths (`C:\` for the root directory, rather than `/`) and the renderer's link replacement logic. - **Media stream error dialog:** Media streams occasionally encounter [this NodeJS stream adapter bug](https://github.com/nodejs/node/issues/54205). This pull request adds a workaround. > [!IMPORTANT] > > This pull request is still a draft -- I would like to do additional manual testing before marking it as ready for review. > # Testing ## New automated tests This pull request adds two automated playwright tests: - `preview pane should render PDFs`: Checks that a single, small PDF loads in the note viewer. - `preview pane should render video attachments`: Verifies that MP4 video attachments can 1) load and 2) that seeking works. I have verified that these automated tests pass on Windows 11 with `yarn test-ui` (note: Windows tests are not run in CI). ## Manual testing (regression testing) **On Windows 11**: - Open a note with an attached PDF, two audio files, and an image. Verify that the audio files can be played and that the PDF renders. - Switch back and forth between the Markdown viewer and Rich Text Editor 10 times, very quickly. Verify that no "Invalid state: Controller is already closed" error dialog box is shown. - Play one of the audio files from the viewer. Type in the markdown editor and verify that the audio file stops playing. - Right-click > "open" the image. - Make a change to the image in an external editor. - I tested by clicking the "rotate" button in the Windows photo viewer app. - Verify that the note viewer re-renders and that the change is shown.

personalizedrefriger · 17 August 2024 19:52

This should be fixed in v3.1.3:

Topic		Replies	Views
PDF Preview Broken Support	0	107	10 November 2024
PDF viewer, audio and video player now in Joplin 1.5 News	18	6877	28 March 2023
PDF preview not working Support	14	1214	7 January 2024
Pdf viewer bug? Why show only half the doc? Features	2	332	4 October 2024
Pdf in a note Support	2	645	22 January 2024