Introducing criticic

criticic · 2024-02-26T17:35:58.789Z

Hello Everyone,

I am Sagnik Mandal, I am a student of Indian Institute of Technology (IIT) (BHU), Varanasi. I have contributed to open source in one way or the other since the last 3 years. Mostly I work with Javascript and Python, but I have worked with some other languages as well like Kotlin & Dart.

There were some project ideas which interested me, mainly "Seamless desktop application updates" & "Create a standalone sync API". I believe I have the suitable skill & experience for those, and would be able to learn things in the way if I dont know something.

I look forward to contributing to Joplin, and help making Joplin the best note taking app (FOSS or otherwise)
You can take a look at my GitHub profile with the same username to check out my contributions.

criticic · 2024-02-27T11:58:43.101Z

I made my first PR here: Desktop: Fixes #9985: Filter Sync Target Info Logs by criticic · Pull Request #10014 · laurent22/joplin · GitHub

I am sorry for closing & reopening the PR as I had misread the guidelines.

criticic · 2024-02-27T12:31:20.763Z

Joplin's Monorepo structure is somewhat new for me, can someone point me to Contributor guidelines, or any suggestions/resources related to working with a mono repo.
I am currently using VSCode, are there any extensions I should use?

RadCod3 · 2024-02-27T12:41:37.953Z

The topic GSoC 2024 live blog has most of the links you'll need. Check out this link for instructions on how to build and run each app in the monorepo: joplin/readme/dev/BUILD.md at dev · laurent22/joplin · GitHub.
Don't forget to use the yarn watch command to automatically rebuild the TypeScript files you have changed.

criticic · 2024-02-27T19:17:39.529Z

can someone take a look at the following changes:

github.com/laurent22/joplin

Desktop: Fixes #10007: Fixed Toggle Comment & Delete Line Options in Beta Editor

committed 06:56PM - 27 Feb 24 UTC

criticic

+5 -1

This fixes Desktop: Beta editor: Toggle comment command does nothing · Issue #10007 · laurent22/joplin · GitHub

is a unit test required here, as its a very small bug fix?

This fixes two (Delete & Comment), while two others (Delete & Sort Selected Lines) would probably require custom commands, which I plan on doing in another PR, if approved.

criticic · 2024-02-28T04:23:49.335Z

I added some tests, and made a PR: Desktop: Fixes #10007: Fixed Toggle Comment & Delete Line Options in Beta Editor by criticic · Pull Request #10016 · laurent22/joplin · GitHub

criticic · 2024-03-01T22:22:41.991Z

I was rereading through the ideas list and the following ideas interested me:

Seamless desktop application updates
Template insertion tool
OneNote importer
Review process for plugins
Create a standalone sync API
Joplin for wearable devices
Integrate Joplin with voice assistants

will prolly narrow down this list in the coming days, one thing I'd like to ask is if I can have two proposals in the same org, and if it is advised to just focus on one?

criticic · 2024-03-20T06:10:00.017Z

I had some work over the last few days, so didnt contribute much, but wold mention that two of my PRs got merged:

github.com/laurent22/joplin

Desktop: Fixes #9985: Filter Sync Target Info Logs

laurent22:dev ← criticic:feat/filterSyncLogs

opened 11:29AM - 27 Feb 24 UTC

criticic

+105 -3

Fixes #9985 . - Removes the Content & Checksum parameters from master keys - Truncates public key to first 40 characters - Truncates provate key to this format: "first20chars...last20chars" - Added testing to check this behaviour

github.com/laurent22/joplin

Desktop: Fixes #10007: Fixed Toggle Comment & Delete/Duplicate/Sort Line Options in Beta Editor

laurent22:dev ← criticic:fix/v6-Comment-n-Delete

opened 04:18AM - 28 Feb 24 UTC

criticic

+187 -1

@PackElend label me please, Fixes #10007 - Fixes the Delete Line & Duplicate Line & Toggle Comment Options in the Beta Editor - Added a test to verify the behaviour

I would continue working on more PRs in the coming days.

laurent · 2024-03-20T13:58:24.557Z

criticic:

will prolly narrow down this list in the coming days, one thing I'd like to ask is if I can have two proposals in the same org, and if it is advised to just focus on one?

To answer your question, you can only have one proposal per org, however besides your main proposal we suggest considering a "backup" project idea in case there's something wrong with the first one.