Hey all. The WIP PR was rejected for more discussion. Laurent had this feedback:
I've installed the feature and looked again as I couldn't understand how it worked at all, but I see a few problems now:
- It relies on the fact that empty search queries returns something. Normally, empty queries are handled at UI level to return nothing. What it returns for empty queries is undefined behaviour and might be changed later on to return nothing.
- It relies on the fact that empty queries return all notes sorted by last updated time. As we are making changes to the sorting algorithm, that might change later on.
- It's loading all the notes in GotoAnything, it would have to be limited to 10-20 notes.
- Finally, while it makes sense to show the last changed notes, it would also make sense to show the last viewed notes. For example, if I look at a note 10 times a day, I might want to see it before some note I modified one week ago.
It works a bit by chance now, and it's not clear to me that we want to see the last modified notes or last viewed ones or a combination of both (there was some discussion about this a while ago to keep track of most viewed notes but it wasn't implemented), so I think the feature would have to be discussed further, better in the forum, and there would be more work to be done.
I agree with this sentiment. While it will take more work, I do think most recently viewed is a better solution than most recently updated. Please feel free to share your preference (@tbergeron do you have a preference?).
Basing it on Views essentially captures Updates and additionally is useful for looking at reference pages.
My only concern is that Views can more easily be false positives. If we base it on any views of the note whatsoever, it often would capture views when browsing, pressing down-arrow to browse through a user's notes. So we would want to make sure the user viewed it for a certain amount of time before counting it as a view, if the view is coming from the notes list.