I continued to work on the GUI keyboard shortcut editor.
The UI is close to what I’m aiming for. However there are some apparent styling issues I encountered which needs to be solved.
I also worked on improving and refactoring my pull requests.
KeymapService: https://github.com/laurent22/joplin/pull/3252
Keyboard Shortcut Editor: https://github.com/laurent22/joplin/pull/3525
I’ll work on integrating Keymap service into GUI shortcut editor once the PR gets merged.
This is really cool! I see you have the helper text “Press the shortcut and hit enter…”. Because you are typing in that area, I don’t know if people will see it. I have a feeling people will hit the “Default” button based on its placement. I wonder if you could have a “Save” and “Revert to Default” buttons to make it more clear? I still think pressing Enter could save it, but the “Save” button might be a nice backup? You could also have the helper text appear below the input box when it is in “edit” mode.
