Week 7: Custom Keyboard Shortcuts

I worked on the GUI keyboard shortcut editor based on sketches I’ve posted here: https://discourse.joplinapp.org/t/keyboard-shortcut-editor-user-interface

PR link: https://github.com/laurent22/joplin/pull/3525

Shortcut recorder component has been implemented. When converting a browser keyboard event to Electron accelerator, there are some differences to consider. The component checks for these differences and gives the appropriate accelerator for each platform.

Several changes and code cleanup was done in my former PR as well.
PR link: https://github.com/laurent22/joplin/pull/3252

I’ve spent most of the time learning and experimenting with React Hooks. It’ll be useful in the coming weeks where I’ll be implementing the logical part of the keyboard shortcut editor.

6 Likes

Sounds good, thanks for the update @anjulak