Question regarding Issue Fix

Development
1

Hi,

I recently worked on this issue: https://github.com/laurent22/joplin/issues/2279

and have a fix here: https://github.com/kirtanprht/joplin/commits/kirtanprht-handle-thai-language

Is the next step to squash the commits and make a pull request to master?

2

Thats correct! @laurent usually squashes the commits when merging so you don’t need to worry about that, just make a pull request! It’s also helpful if you can write up a few sentences explaining your changed if you think any of it might be confusing.