How can I refer the plugin settings from contentScript?

uphy · 6 March 2021 07:31

I'm developing a plugin that enables embedding PlantUML diagrams in markdown.

I have defined settings like below:

uphy/joplin-plantuml-plugin/blob/aa11e3b27e9f90680e54711bb07b7d7fbe32573f/src/settings.ts#L15-L38


export async function registerSettings() {
    await joplin.settings.registerSection(settingSection, {
        label: 'PlantUML',
        iconName: 'fas fa-sitemap'
    });

    await joplin.settings.registerSetting(settingKeyOpenMarker, {
        type: SettingItemType.String,
        value: '@startuml',
        description: 'String to use as opening delimiter.',
        section: settingSection,
        public: true,
        label: 'Open Marker'
    });

    await joplin.settings.registerSetting(settingKeyCloseMarker, {
        type: SettingItemType.String,
        value: '@enduml',
        description: 'String to use as closing delimiter.',
        section: settingSection,

This file has been truncated. show original

And I have tried to refer the settings from here in contentScript

github.com

uphy/joplin-plantuml-plugin/blob/aa11e3b27e9f90680e54711bb07b7d7fbe32573f/src/markdownItPlantUmlPlugin.ts#L4-L9


const markdownItPlantUml = require('markdown-it-plantuml');
markdownIt.use(markdownItPlantUml, {
    // How can I refer settings from here?
    openMarker: '@startuml',
    closeMarker: '@enduml',
});

But it seems that we can't use plugin's API from there.

How can I refer the plugin settings from contentScript?

roman_r_m · 6 March 2021 08:27

Send a message to your plugin, get settings in the plugin, send the result back to the contentscript.

uphy · 6 March 2021 08:46

Thank you for your reply!

I have defined onMessage() which returns settings and tried to get the settings from contentScript,

But it seems not allowed for markdown-it plugin.

loadContentScripts: context.postMessage is not available to renderer content scripts

github.com

laurent22/joplin/blob/e595e19c0daa2f68792885b4b9b55960ccefff16/packages/lib/services/plugins/utils/loadContentScripts.ts#L18-L20


		if (scriptType === ContentScriptType.MarkdownItPlugin) {
			logger.error('context.postMessage is not available to renderer content scripts');
		} else {

laurent · 6 March 2021 09:58

Hmm, I don't think that's possible actually. You can post messages from the HTML that the content script generates, but you can't when you instantiate the Markdown-it plugin. Maybe some way to do this should be provided via the context variable.

laurent · 6 March 2021 10:01

If I may make a suggestion, it would make sense to use a fence like this to delimit the UML code:

```plantuml
Bob -> Alice : Hello
```

That would be consistent with how it's done for Mermaid, Fountain, etc.

uphy · 6 March 2021 10:27

Thank you for the suggestion!
Now I'm using it as fence.

By the way, I want to switch PlantUML server by settings.
Currently I'm using a public PlantUML server. This means that we can't use this plugin with confidential information.

To switch the server, would you consider to give us a way to get settings from content script?

laurent · 6 March 2021 10:32

Yes I think we should add this. Calling postMessage at this point would be tricky because it's async, and that function is synchronous. Perhaps it's a matter of allowing to pass variables from the plugins via the context parameter.

uphy · 6 March 2021 10:37

It's nice idea. I'm looking forward to the feature being implemented.

rxliuli · 6 March 2021 16:55

I do not recommend to provide it directly, because there are too many tool libraries for encapsulating postMessage/onMessage, the most typical one is ChromeLab’s comlink, ref: GitHub - GoogleChromeLabs/comlink: Comlink makes WebWorkers enjoyable.

ocelotsloth · 31 March 2021 16:12

+1

@uphy I just went down this same path trying to modify your plugin to add the ability to change the PlantUML server.

For a variety of reasons I cannot use the public PlantUML server for work.

In the meantime--I'll just run a custom version of your plugin that hard-codes the change.

victorkane · 15 June 2021 14:42

@uphy I am overjoyed with this plugin, thanks so much for creating it. I began using it and testing it out pretty thoroughly over the past few days.

I am using the Joplin desktop version with Dropbox sync both on a MacBook Air and on a PC with Ubuntu 20.04. What I describe below occurs equally, exactly the same, on both machines.

I found that it works well, but every now and then (after extended use, especially with standard library examples from the Hitchhikers Guide docs???) it causes Joplin to crash with an error report. This is sporadic, not connected to errors or length (previous short examples which worked fine before sometimes end up with a Joplin error page making a reboot in safe mode. When this happens, the page causing the crash causes it on both machines.

I am using everything out of the box, although I did install a local PlantUML server with docker, I did not see any settings page in order to try everything out with a local server (I have since read other comments touching on this).

I am willing to do extensive testing if when there are updates to the plugin.

Again, thanks so much for the contribution.

ocelotsloth · 19 July 2021 04:52

I think you're running into this issue: plugin causes a crash · Issue #3 · uphy/joplin-plantuml-plugin · GitHub

There's a patch (Fix plugin crashing joplin (#3) by mablin7 · Pull Request #4 · uphy/joplin-plantuml-plugin · GitHub) that's already been merged to fix. Hopefully we can get a new version released before too much longer.

marc0l92 · 17 September 2021 22:50

Hello, I'm facing the same communication issue with my plugin.
Do you have an example of plugin that is using the method you suggested with Comlink?

Thanks

laurent · 18 September 2021 00:00

What kind of content script? And what does it do?

marc0l92 · 18 September 2021 07:36

I would like to update the jiraIssue plugin I created in order to use content script.

The current version generates markdown that is automatically rendered.
The problem with this approach is that I pollute the note with a lot of text.
With a content script I could hide this inside the html and css and create a nicer output.

I'm currently not able to read the plugin settings from the content script.

The only way I found to communicate between content script and plugin is to use the webviewApi.postMessage. This api is only available in the rendered HTML and I cannot run it without a user input (like the click of a button or link like you did in the contentScript plugin example).

Can you suggest me another approach?

marc0l92 · 23 September 2021 11:20

The only way I found to get the settings from the contentScript is to:

create a contentScript plugin that does nothing
in the html rendered by the contentScript I call the webviewApi sending the content written inside the fence
the joplin plugin combines the content with the settings and replays with the new HTML that will replace the HTML that was calling the webviewApi

I had some problem figuring out how to call the webviewApi when the markdownIt page was rendered, but I finally managed to find a solution.

I use the event:

<style onload=" here the javascript to call the webviewApi" ></style>

I'm not sure this will help the plantuml plugin because it needs the settings to be accessed in the contentScript and not in the HTML rendered by the contentScript.

I hope this can help other plugin developers.
Let me know if you need more details.

extall · 25 September 2021 11:18

Well, exactly, this seems to be the only way to do it now and it imposes quite a few limitations. I've spent quite a bit of time trying to rework the BibTeX plugin but in the end I had to start digging into Joplin's source code as the plugin API just does not provide enough features at the moment. We'll see how that goes.

marc0l92 · 17 February 2022 11:32

Please, let us know if you find any ineresting hack to have access to some internal features