Corrupted notes?

personalizedrefriger · 21 November 2024 14:50

I'm linking to a related pull request:

github.com/laurent22/joplin

Mobile: Fixes #11317: Fix race condition which may cause data loss, particularly before or after pasting text in the note editor

laurent22:dev ← mrjo118:race-condition-data-loss

opened 02:35PM - 07 Nov 24 UTC

mrjo118

+1 -2

There have been various issues raised regarding the latest input text intermitte…ntly being lost on a note on the mobile app. I have managed to find a way to consistently recreate this issue. By adding additional logging at various places and then reproducing the issue, I was able to figure out the root cause of the issue. The issue is caused by a race condition in saveNoteButton_press. If the execution of the method overlaps, when "BaseModel.diffObjectsFields(comp.state.lastSavedNote, note)" is executed, it will incorrectly think that the note has not changed, when the value of comp.state.note has changed between entering the method and setting the stateNote field. Therefore the subsequent logic to save the note to the database will not save changes updated after saving the note, but before setting stateNote. The fix for this is to simply set the lastSavedNote value (used for comparing the previous note state) to use the 'savedNote' value, rather than the 'note' value which may have newer changes than 'savedNote'. See https://github.com/laurent22/joplin/issues/11317 for a video of the issue being reproduced. EDIT: an additional change was required to ensure that if the note was exited quickly after making the last change, no input data would be lost. The updated video demonstrates no input being lost after a rapid exit of the note after making changes. Attached are videos of the behaviour following the code change. Exit note slowly, showing latest input renders correctly in view mode when exiting edit mode: https://github.com/user-attachments/assets/e2af19b2-3296-40f1-9ad9-7b8f2b9c4cff Exit note quickly, without waiting for note to re-render: https://github.com/user-attachments/assets/b0df0a13-7811-463e-9ad1-97ceab8b8202 PLEASE NOTE: The CodeMirror error which pops up at the start of the video is pre-existing, and happens sometimes when opening very large notes in edit mode. But the error popup is not visible when running the published app (but the error can still be found in the logs) rather than a dev build

It should be included in the Android v3.2.2 pre-release.

Topic		Replies	Views
Some notes just... disappeared Support	5	1411	14 February 2022
Data loss Support	2	478	7 May 2019
Data recover help! - data conflict in different terminal (windows and android) Support	0	352	29 September 2020
Rarely, final characters in note edits go missing Support	2	442	21 October 2019
Notes don't sync to desktop but do sync to phone, "Error: Missing required property" Support	6	904	19 December 2020

Corrupted notes?

Related topics