If you do have to make your own library, you have the time to support it for a good while, and / or Joplin decides to use it in the main app, it’d probably be a good idea to open source it under MIT or BSD licenses and make it an official module at some point. Simple modules like these are always in demand and would definitely look good on your resume when you graduate. Food for thought.
1 Like
Doesn’t seem like a good idea to me. Say I put my phone down for a minute while I do something else. I’m with other people I know, so I don’t bother locking it; I plan to return in a couple minutes. While I’m away, somebody I know picks up my phone and sees this little eye icon. He taps it, and my master key password is revealed in plain text. He makes a mental note of it and puts the phone down. Some time later, after the room has cleared out, he returns to my phone, unlocks with the master key, and makes mischief.
This has too many potential issues and not enough benefit. If I can’t remember my master key password, then email it to me, or maybe reveal it by reading my fingerprint.
1 Like
Sir, exactly that’s the feature we all try to implement. Using phone lock for security. And sir, this master key is for encrytion only, no one can unlock your phone with this password. And if somehow they got your phone unlocked, they can edit or delete your joplin notes without seeing this masterkey. For more details, please read above comments.
There is lot of talking here what is really good but we risk to go off course.
So you may come up with little flow chart visualising the use cases.
draw.io may helps you doing this
1 Like
Sir I am doing some research and I think there might be a problem in what we are thinking of implementing right now, but still I will first confirm and will make a diagram.
2 Likes
Every design decision is a trade-off, so I feel like what makes sense here is to look at the costs and benefits and see if the trade-off is worth making. The costs here seem pretty clear - decreased security and increased complexity. The only mention of benefits I see is “It can be convenient in some cases, for example if you forgot your password, or to verify what you’ve just typed” in the initial post.
That feels very vague and hypothetical to me and to me it doesn’t look like the benefits justify the costs (and I personally would rather not have this feature in the app). But if someone can better explain the benefits of this feature and how they can outweigh the costs, I think that would help ensure the right considerations go into this decision. If there’s a solid reason to believe this feature would help users, it’d be good to air that.
8 Likes