Mobile: Markdown Toolbar

[personalizedrefriger]

Thank you for testing the APK!

@dimi-huer

I found the placement of formatting (bold, italicize) together with code and link a bit counterintuitive and would expect it to be first a separate group and second either the first item or between headers and lists.

I grouped the functions that I frequently used together in the same submenus. This is a good argument for customizability!

I would like to get a functional version of the toolbar merged before adding customizability, however — I plan to spend the second half of GSoC on a different component of the mobile editor.

@dimi-huer

I've had moments when the "hide keyboard button" disappeared. I can't really reproduce it in a consistent manner. It happened after I played around several times with lists or sometimes if I would start to edit a note again.

I've noticed that, too, but only on Android (edit: but only on my physical Android device — not on the emulator).

I haven't noticed this happening on iOS (yet), which is where the button is most needed (I'm hiding the built-in done button on iOS for extra space). I could remove it from the toolbar on Android, but I still find it more convenient than hiding the keyboard with the system button.

I'm currently showing/hiding the button based on Keyboard::keyboardDidShow and Keyboard::keyboardDidHide events. I could instead show/hide the button based on whether the WebView has focus, but this wouldn't handle the case where the search dialog has focus and would show the 'hide keyboard' button even if the user is using a hardware keyboard...

@dimi-huer

1. I couldn't add a list in the style ordered - unordered:

1. Item
    - Subitem
2. Item
    - Subitem

If I change a subitem to be unordered instead of ordered the whole list changes to be unordered. I think the function should only act on the same level of the list, but it should act on the whole list if all of it is selected.

That should be fixed in version 6!
Edit: It works in version 6, but the list items need to have different indentation levels before pressing the toggle button. Changing this to always not auto-select the containing list could make sense, though!