The original markdown toolbar pull request had a roughly 7,000-line diff. Most relevant files are in the NoteEditor folder.
Because this is much too long to be comfortably reviewable, I would like some advice on how to break it up.
I currently plan on breaking it into four separate PRs:
- Set up the mobile repository for testing with
jest
- Add syntax highlighting for math, code, etc.
- Add commands that will be used by the markdown toolbar and tests (see markdownCommands.ts and markdownCommands.test.ts)
- Add the markdown toolbar and connect the commands to it
PRs 2 and 3 in the list above will still be quite long.
Note that I'm still receiving feedback (a large portion of which has to do with bugs!) and, because the PRs will depend on each other (the markdown toolbar, for example, needs the markdown commands) may be backporting fixes from my main development branch. Should I postpone fixing small bugs until after the PRs have been reviewed/merged? Should I wait until I've found/fixed more issues with the markdown commands/the toolbar?
How should I break up the original PR?