This is the combined report of the last two weeks.
Firstly, I focused on getting the remaining pr merged :
- Tools: Resolves #15974: Added new publish plugin command in plugin-repo-cli by akshajrawat · Pull Request #15981 · laurent22/joplin · GitHub (Merged)
- https://github.com/laurent22/joplin/pull/16022 (in review)
Then I focused on reviewing and refining all the workflow code in Plugins-test repository, few changes were done and repetitive code was reduced.
While reviewing I came across a bug where the regression test on the 20 plugins was generating false positive pass result when there was even a single clean scan result. This was fixed.
After that I reviewed the custom written CodeQl rules and matched them with their description in rules.md. While reviewing I found out that several test were actually missing few things. Then I updated those rules and their test cases respectively.
All rules can be found in this dir : RULES
All tests can be found in this dir : TEST
Then I ran those tests on the top 20 plugins and made sure they produce no findings.
Then I made 10 plugins which contain the code as in TEST dir and submitted them to github. These are the scan results of those 10 plugins :
- [Plugin Submission] joplin-plugin-rule-group-1 v1.0.0 · Issue #29 · joplin/plugins-test · GitHub
- [Plugin Submission] joplin-plugin-rule-group-2 v1.0.0 · Issue #30 · joplin/plugins-test · GitHub
- [Plugin Submission] joplin-plugin-rule-group-3 v1.0.0 · Issue #31 · joplin/plugins-test · GitHub
- [Plugin Submission] joplin-plugin-rule-group-4 v1.0.0 · Issue #32 · joplin/plugins-test · GitHub
- [Plugin Submission] joplin-plugin-rule-group-5 v1.0.0 · Issue #33 · joplin/plugins-test · GitHub
- [Plugin Submission] joplin-plugin-rule-group-6 v1.0.0 · Issue #34 · joplin/plugins-test · GitHub
- [Plugin Submission] joplin-plugin-rule-group-7 v1.0.0 · Issue #35 · joplin/plugins-test · GitHub
- [Plugin Submission] joplin-plugin-rule-group-8 v1.0.0 · Issue #36 · joplin/plugins-test · GitHub
- [Plugin Submission] joplin-plugin-rule-group-9 v1.0.0 · Issue #37 · joplin/plugins-test · GitHub
- [Plugin Submission] joplin-plugin-rule-group-10 v1.0.0 · Issue #38 · joplin/plugins-test · GitHub
NEXT WEEK PLAN
- Getting the last pr merged
- Checking all the submission paths (new submission, update with version bump, update without version bump, etc )
- Removing any redundant code or file
- Documenting all the progress and features in a clean md file
- Getting the final video of the whole process recorded
- Change the test package with official package. Currently I am using
@akshajrawatt/plugin-repo-cli@1.0.5test package for publish job since@joplin/plugin-repo-clilatest code is not published yet.