laurent22:dev
← laurent22:codemirror_theme_update
opened 04:22PM - 10 Jul 21 UTC
The goal of this pull request is to make the CodeMirror style look more like for…matted text and less like code. In practice the changes are:
- Applied the currently loaded theme to the CodeMirror elements (bold, headers, rules, etc.)
- Increased the default font size so that it matches the viewer size
- Also tweaked the URL style so that both text and URL have the same colour, but the URL is slightly dimmed (50% opacity)
I assume it's mostly a positive change, but I'm putting it here in case anyone has any suggestion or can see any issue with this approach. Also @CalebJohn, I assume it won't conflict with your Rich Markdown editor but if you think it might (since I'm tweaking the CSS) let me know.
## Light theme
| Before | After |
| --- | --- |
| ![image](https://user-images.githubusercontent.com/1285584/125169374-bf46bb00-e1a1-11eb-84a0-f5a4fbc23aee.png)| ![image](https://user-images.githubusercontent.com/1285584/125169245-3039a300-e1a1-11eb-9bf4-f71658983de0.png) |
## Dracula theme
| Before | After |
| --- | --- |
| ![image](https://user-images.githubusercontent.com/1285584/125169357-ad651800-e1a1-11eb-8d9b-31b157385155.png)| ![image](https://user-images.githubusercontent.com/1285584/125169460-25cbd900-e1a2-11eb-878b-16be6a9be699.png) |