Button's text looks too big

[antoniopaolini]

Going from version 2.5.12 to 2.6.2 the text in the buttons grew.
I don't know if it's intentional, but the effect is not aesthetically pleasing.

What do you think about it?

Bye.

[antoniopaolini]

Not only button. Also the text in the notebook list is abnormally spaced (like the inglorious gmail's "comfortable density" setting).
IMHO it is very uncomfortable, because we can see less item.

I

[Daeraxa]

Agree, something has definitely changed (although Discourse currently isn't allowing me to upload an image for some reason).
Probably worth opening an issue on GH for this as it doesn't seem to be an intended change judging by the change notes.
I've got 2.5.1 side to side with the current dev build and the spacing of a lot of items has changed.

Looking at the dev tools inspecting the buttons:

2.5.1

button {
	cursor: pointer;
}

dev build

body, button {
	color: var(--joplin-color);
	font-size: 16px;
}
...
button {
	cursor: pointer;
}

Building having removed the , button from main.scss returns the button font size to the 2.5 version.

This commit certainly seems to be responsible for the button font size change: Desktop: Allow showing passwords in Master Password dialog · laurent22/joplin@79d97f2 · GitHub as it has the above addition in the main.scss file

Not found what is causing the note list change yet.
Have had a quick dig and found one small change, not sure how it is entirely related, span.title in the note list now has a line-height: 0 style which is not present in 2.5.

<span class="title" style="line-height: 0;">bAnotherNotebook</span>

[antoniopaolini]

Hello,
Thanks for the hint!

I resolved putting in userchrome.css this section:

button {
	font-size: 13px;
	/*font-size: unset; DON'T WORKS!*/
	}
.sidebar .list-item-container{
	height: 25px !important;
}

I reported this change as issue #5783
Bye!

[UPDATE: 2021-11-25] I added class "sidebar" because if not add this condition I have a side effect that resize also the note list panel in a strange way (the list of notes only goes down to a certain point even though it is longer and I can scroll through it).

[Eduardo]

Hi as I've dealt with similar issue
I have added your lines into the userchrome.css and font looks back as usual, but every time I open Joplin I can see the developer tool as attached.

Although, I can close it and using Joplin without any problem, could somebody help me to update userchrome.css to avoid this issue when I try to open Joplin? Thanks

Joplin 2.6.2 (prod, linux)
Sync Version: 3
Profile Version: 41

[Daeraxa]

Could you paste what is in your userchrome?
That box usually shows up when you run Joplin with a development plugin specified:

[Eduardo]

Hi @Daeraxa ,
Right, this issue is not relate to the userchrome file as I assumed, I had a plugin path in a development plugin field mentioned by you. Thanks.

[Daeraxa]

I had forgotten about the issue with the sidebar item spacing mentioned here until I upgraded my main profile to 2.6.9 today. Was this change intentional (for the notebook icons?) along with the button label change?

[antoniopaolini]

@Daeraxa

Was this change intentional (for the notebook icons?)

I think so, but also with my workaround (see above) the notebook icons are displayed well.

I yet used to put some emoji in my title, but obviously this way change the alphabetical order of the notebooks. I'm happy with this (I use to put "flame", arrow and other emoji to highlight temporarily the notebooks I'm working on).
The notebook icons, on the other hand, are better if you don't want tho mess the order but I can't understand how to reduce their dimension via userchrome.css.

Happy Holidays for all the developers!!!
Best wishes to everybody!!!