Hello, I am looking for support in what am working on. I am working to fix an issue https://github.com/laurent22/joplin/issues/2595
Now, I submitted 3 PR for this
First PR => I actually mad a hack to do implement the undo/redo functionality in mobile and I didn’t think for most of the cases in which it would have not worked. So, it was closed by Laurent
Second PR => I took a look at the code of most of the undo-redo js library and based on it I created the file UndoRedoService in which I wrote the logic to do the undo-redo operation. As per me this was good and worked in most of the cases but the code quality was bad.
Then only I thought of creating the fresh PR
- Third PR => In this PR I improved the code quality, added comments in code everything was good according to me but it Travis build failed. Then I got to remember about the contributing guide new file inside lib should be unit tested.
Now I have created a file UndoRedoService.ts which does the undo-redo operation for mobile.
I just want to know if am doing the right way or if this way I was not supposed to do and am just pushing myself for no reason. I know most people will definitely be angry about this but I really want to contribute to Joplin development