Why doesn't the mobile app ask to resize image down to 1920p?

m-pawelczyk · 2023-09-11T19:00:47.028Z

I have just tested with "Always ask" (not asking) and "Always resize". Both not working
version 2.12.2

laurent · 2023-09-11T19:13:06.345Z

I've just tried and it's working fine for me with "Always ask". Could you provide the image you are trying to attach?

m-pawelczyk · 2023-09-11T19:28:06.380Z

20230909_1907151920×1436 124 KB

I have played with this image. Not working for me. Just tried second time with this.

m-pawelczyk · 2023-09-11T19:30:50.881Z

Looks like image is resized when I have added it here because here is info

Screenshot 2023-09-11 at 21.28.55247×801 83.3 KB

laurent · 2023-09-11T19:35:01.857Z

Hmm, yes it's 1920px here, so it wouldn't be resized. Are you able to upload it somewhere so that we can download it as it is (without being converted by some service)? Or compress it as zip first

m-pawelczyk · 2023-09-11T19:37:31.078Z

20230909_190715.jpg.zip (2.0 MB)

ZIP should work

m-pawelczyk · 2023-09-11T19:38:02.583Z

ZIP should work
20230909_190715.jpg.zip (2.0 MB)

m-pawelczyk · 2023-09-11T19:44:54.977Z

https://u.pcloud.link/publink/show?code=XZoqo3VZSVdJpvPTV47cLLRsTUs2CRsPmDyy

You should be able to download. There is option of direct download without need of login to pcloud

m-pawelczyk · 2023-09-11T19:53:50.559Z

I hope that you see above post because I got message that some is hidden, probably when I have tried to send ZIP file

chentao · 2023-09-12T09:44:10.245Z

Thanks, it works fine now too. My app wasn't up to date, didn't have the "resize" option (I guess it's been added fairly recently).

chentao · 2023-09-12T09:46:33.528Z

I just upgraded to version 2.12.3 on Android, it works fine. Try and upgrade to the latest version. Are you on Android or iOS ?

chentao · 2023-09-12T10:28:09.625Z

I just tested with your 4348x3251px picture, and indeed it doesn't ask to resize.

There must be something special with it, because I tested a dozen other pictures, it always asked to resize. Can you try with some other pictures ?

m-pawelczyk · 2023-09-13T18:12:17.809Z

I just tested with your 4348x3251px picture, and indeed it doesn't ask to resize.

It is simply photo from my phone - Samsung A52 so quite popular model

I have tested picture downloaded from internet and indeed it was, resized. Than I have tested with some other pictures from my gallery and it works 50/50. Some are resized some not Don't know what is an issue

m-pawelczyk · 2023-09-23T19:40:53.012Z

I think I have found at least one different between photos which are asked to be resized with this which are not.

When I add to Joplin app original photo -> Joplin ask to resize it.

When I add a little cropped but still big photo - Joplin not asking to resize it The same with scans which I always crop during scanning.

Do you have any idea why is like this?

wh201906 · 2023-09-25T13:54:13.321Z

The library used for checking size reports 1087x813 for this image.

wh201906 · 2023-09-25T14:06:17.108Z

It seems that the Image.getSize() doesn't report the pixel size on Android

github.com/facebook/react-native

[Android] Image.getSize returns wrong dimensions

opened 11:55AM - 05 Nov 18 UTC

closed 09:15AM - 10 Dec 18 UTC

Fsarmento

Platform: Android Resolution: Locked API: Dimensions Component: Image

- [x] Review the documentation: https://facebook.github.io/react-native - [x]… Search for existing issues: https://github.com/facebook/react-native/issues - [x] Use the latest React Native release: https://github.com/facebook/react-native/releases ## Environment React Native Environment Info: System: OS: macOS 10.14 CPU: x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz Memory: 47.52 MB / 8.00 GB Shell: 3.2.57 - /bin/bash Binaries: Node: 8.11.1 - /usr/local/bin/node Yarn: 1.10.1 - /usr/local/bin/yarn npm: 6.4.1 - /usr/local/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman SDKs: iOS SDK: Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1 IDEs: Android Studio: 3.1 AI-173.4907809 Xcode: 10.1/10B61 - /usr/bin/xcodebuild npmPackages: react: 16.5.0 => 16.5.0 react-native: 0.57.1 => 0.57.1 npmGlobalPackages: react-native-cli: 2.0.1 react-native-create-library: 3.1.2 react-native-git-upgrade: 0.2.7 ## Description Image.getSize does not return the correct width and height of the image. See the example below: ``` // uses RNCamera from 'react-native-camera' takePicture = async (camera: any) => { const options = { quality: 0.5, base64: false, } const metadata = await camera.takePictureAsync(options) const { uri, width, height } = metadata console.log({ width, height }) if (isAndroid) { Image.getSize(uri, (w, h) => { console.log({ width: w, height: h }) }) } } ``` console.log results: metadata from takePictureAsync: { width: 2592, height: 1944} result from Image.getSize: { width: 1296, height: 972 } I confirmed after exporting the picture that the real dimensions are the ones from takePictureAsync. ## Reproducible Demo see the example

We might need this package

npm

react-native-image-size

Get original image size (iOS + Android). Latest version: 1.1.5, last published: 5 days ago. Start using react-native-image-size in your project by running `npm i react-native-image-size`. There are 8 other projects in the npm registry using...

laurent · 2023-09-25T14:16:18.639Z

I was just looking into this and notified the upstream package:

github.com/facebook/fresco

[Android][react-native] incorrect image width and height - CloseableImage getWidth/getHeight

opened 12:52PM - 06 Nov 18 UTC

Fsarmento

bug

### Description On react native, `Image.getSize() ` uses Fresco ([here](htt…ps://github.com/facebook/react-native/blob/0a39cda39a83313fa1628759b2735d58ffcc02ec/ReactAndroid/src/main/java/com/facebook/react/modules/image/ImageLoaderModule.java#L71)) to return the width and height of a given image. As explaned in this react-native issue (https://github.com/facebook/react-native/issues/22145), the returned width and height are inconsistent in Android. The ratio between width and height is correct, but the values of width and height are not. ### Reproduction See example in https://github.com/facebook/react-native/issues/22145 ### Additional Information react: 16.5.0 => 16.5.0 react-native: 0.57.1 => 0.57.1 * Fresco version: com.facebook.fresco:fresco-1.10.0 * Platform version: Android 6.0.1 (One plus One); Android 7.0 (Huawei MediaPad T3 10);

That react-native-image-size package unfortunately doesn't even build (Java code is invalid), I think the owner messed up a merge and didn't check if it was still working:

https://github.com/eXist-FraGGer/react-native-image-size/commit/6927595b701f169067e6aa2aa7ec74c0aac7bf4a#r128304078

wh201906 · 2023-09-25T15:31:35.977Z

From the issue you mentioned I guess they don't want to change the behavior of getSize().

github.com/facebook/fresco

[Android][react-native] incorrect image width and height - CloseableImage getWidth/getHeight

opened 12:52PM - 06 Nov 18 UTC

Fsarmento

bug

### Description On react native, `Image.getSize() ` uses Fresco ([here](htt…ps://github.com/facebook/react-native/blob/0a39cda39a83313fa1628759b2735d58ffcc02ec/ReactAndroid/src/main/java/com/facebook/react/modules/image/ImageLoaderModule.java#L71)) to return the width and height of a given image. As explaned in this react-native issue (https://github.com/facebook/react-native/issues/22145), the returned width and height are inconsistent in Android. The ratio between width and height is correct, but the values of width and height are not. ### Reproduction See example in https://github.com/facebook/react-native/issues/22145 ### Additional Information react: 16.5.0 => 16.5.0 react-native: 0.57.1 => 0.57.1 * Fresco version: com.facebook.fresco:fresco-1.10.0 * Platform version: Android 6.0.1 (One plus One); Android 7.0 (Huawei MediaPad T3 10);

As for the react-native-image-size, the repo is active and I think the bug will be fixed soon.

m-pawelczyk · 2023-10-09T18:30:28.884Z

Should I open bug or feature request on github?

I am not sure if there should be used different lib or just different method like takePictureAsync ?

m-pawelczyk · 2023-10-27T16:21:25.375Z

So do you think that we will wait until it will be changed on android? Maybe at least always resize could work on Android?