Use Pull Requests code review to avoid issues

Gsandec · 2020-08-04T16:59:46.691Z

I've forked your repo (congrats on your project) and implemented a code review tool to check a few pull requests and found a couple issues in seconds.

This maybe useful for your project. Free for open source
(mind that you and your contributors can see comments on code reviews directly inside your GitHub account!)

Disclaimer: I work at Codacy and I'm trying to get closer to this amazing open source community!

Captura de ecrã 2020-08-04, às 17.40.161896×884 135 KB

Captura de ecrã 2020-08-04, às 17.41.372840×1522 389 KB

Captura de ecrã 2020-08-04, às 17.41.532864×1550 498 KB

naviji · 2020-08-06T09:42:17.592Z

I guess it would be better to be explicit about the base when using parseInt(). Thanks.

laurent · 2020-08-06T10:15:16.364Z

Yes I’ve ended up adding this eslint rule based on this report: https://github.com/laurent22/joplin/blob/b0b55718cc19bcf013e04d0e293893cbf2cd52c2/.eslintrc.js#L64