Use Pull Requests code review to avoid issues

Development
#1

I've forked your repo (congrats on your project) and implemented a code review tool to check a few pull requests and found a couple issues in seconds.

This maybe useful for your project. Free for open source :slight_smile:
(mind that you and your contributors can see comments on code reviews directly inside your GitHub account!)

Disclaimer: I work at Codacy and I'm trying to get closer to this amazing open source community!

Captura de ecrã 2020-08-04, às 17.40.16
Captura de ecrã 2020-08-04, às 17.40.161896×884 135 KB
Captura de ecrã 2020-08-04, às 17.41.37
Captura de ecrã 2020-08-04, às 17.41.372840×1522 389 KB
Captura de ecrã 2020-08-04, às 17.41.53
Captura de ecrã 2020-08-04, às 17.41.532864×1550 498 KB

#2

I guess it would be better to be explicit about the base when using parseInt(). Thanks.

1 Like
#3

Yes I’ve ended up adding this eslint rule based on this report: https://github.com/laurent22/joplin/blob/b0b55718cc19bcf013e04d0e293893cbf2cd52c2/.eslintrc.js#L64