Home / GitHub Page

Search text in `search in current note` is black in dark theme

Joplin: git master 675ef8a

Edit -> Search in current note:

image

@mic704b any chance this has anything to do with your changes to the search bar code?

Yes, it appears so. I’ll fix it ASAP.

I was faster :grin: https://github.com/laurent22/joplin/commit/c63d8a70b8bb45049058baa545a9c83de4fb1ae8

haha. Good times.

@laurent unrelated to this, I get the follwing error when doing a ./run.sh:

(I’ve run npm i in all required directories)

Uncaught Error: Cannot find module './MdToHtml/rules/sanitize_html'
Require stack:
- /Users/tessus/data/work/joplin/ElectronClient/app/lib/joplin-renderer/MdToHtml.js
- /Users/tessus/data/work/joplin/ElectronClient/app/lib/joplin-renderer/MarkupToHtml.js
- /Users/tessus/data/work/joplin/ElectronClient/app/lib/joplin-renderer/index.js
- /Users/tessus/data/work/joplin/ElectronClient/app/lib/markdownUtils.js
- /Users/tessus/data/work/joplin/ElectronClient/app/lib/models/BaseItem.js
- /Users/tessus/data/work/joplin/ElectronClient/app/lib/models/Note.js
- /Users/tessus/data/work/joplin/ElectronClient/app/lib/reducer.js
- /Users/tessus/data/work/joplin/ElectronClient/app/lib/BaseApplication.js
- /Users/tessus/data/work/joplin/ElectronClient/app/app.js
- /Users/tessus/data/work/joplin/ElectronClient/app/index.html
    at Module._resolveFilename (internal/modules/cjs/loader.js:717)
    at Function../lib/common/reset-search-paths.ts.Module._resolveFilename (reset-search-paths.ts:40)
    at Module._load (internal/modules/cjs/loader.js:622)
    at Module._load (electron/js2c/asar.js:717)
    at Function.Module._load (electron/js2c/asar.js:717)
    at Module.require (internal/modules/cjs/loader.js:775)
    at require (internal/modules/cjs/helpers.js:68)
    at Object.<anonymous> (/Users/tessus/data/work/joplin/ElectronClient/app/lib/joplin-renderer/MdToHtml.js:16)
    at Object.<anonymous> (/Users/tessus/data/work/joplin/ElectronClient/app/lib/joplin-renderer/MdToHtml.js:258)
    at Module._compile (internal/modules/cjs/loader.js:880)

Did you npm run tsc?

No, because this was done automatically by run.sh or actually build.sh.

ok, this worked. Thanks!

Quick Draw McGraw
image

1 Like