Linux - Profile switch warning

dpoulton · 2022-12-09T17:20:14.063Z

When changing profiles on a Linux system the Joplin application suddenly closes and looks like a program crash (it isn't). It is suggested that when changing profiles on Linux the restart warning used for plugins is triggered.

shutdown

MrKanister · 2022-12-09T19:27:38.779Z

I noticed this some time ago, too. It's a little bit irritating. I have looked into it and it seems to be like this because the profile switching calls restart with a false argument

github.com

laurent22/joplin/blob/f712e1bdbbd8f3cbcb72aff4fc52dc9ecf433354/packages/app-desktop/commands/switchProfile.ts#L23


      
          		execute: async (context: CommandContext, profileId: string) => {
          			const currentConfig = context.state.profileConfig;
          			if (currentConfig.currentProfileId === profileId) return;
          
          
			const newConfig: ProfileConfig = {
          				...currentConfig,
          				currentProfileId: profileId,
          			};
          
          
			await saveProfileConfig(`${Setting.value('rootProfileDir')}/profiles.json`, newConfig);
          			await restart(false);
          		},
          	};
          };

and thus doesn't open the message box here (because linuxSafeRestart is false):

github.com

laurent22/joplin/blob/f712e1bdbbd8f3cbcb72aff4fc52dc9ecf433354/packages/app-desktop/bridge.ts#L279


      
          		// Note that in this case we are not sending the "appClose" event
          		// to notify services and component that the app is about to close
          		// but for the current use-case it's not really needed.
          		const { app } = require('electron');
          
          
		if (shim.isPortable()) {
          			const options = {
          				execPath: process.env.PORTABLE_EXECUTABLE_FILE,
          			};
          			app.relaunch(options);
          		} else if (shim.isLinux() && linuxSafeRestart) {
          			this.showInfoMessageBox(_('The app is now going to close. Please relaunch it to complete the process.'));
          		} else {
          			app.relaunch();
          		}
          
          
		app.exit();
          	}
          
          
	public createImageFromPath(path: string) {
          		return nativeImage.createFromPath(path);

laurent · 2023-06-08T13:47:22.646Z

Maybe we could actually remove this exception for Linux. I assume it was added because some distro somewhere didn't handle restart properly. If someone is willing to remove that exception and test I'd be happy to merge

Herve · 2023-06-19T20:29:04.234Z

Hello
I'm not a developer, but I can't wait for you to make it quick and easy to switch from one profile to another

Herve · 2023-07-05T07:47:37.296Z

Hello
At the moment I'm not using this because of the problem of switching quickly.
Is it planned? next version?

laurent · 2023-07-05T11:40:12.848Z

laurent:

Maybe we could actually remove this exception for Linux. I assume it was added because some distro somewhere didn't handle restart properly. If someone is willing to remove that exception and test I'd be happy to merge

FYI

LeoK987 · 2023-11-12T06:44:22.401Z

I changed the code to the following and it's working fine seemingly without any issue. I run it on Manjaro KDE Wayland.

Note I changed app.exit() to app.quit(). quit is supposed to do a graceful exit.

	public restart(linuxSafeRestart = true) {
		const { app } = require('electron');

		if (shim.isPortable()) {
			const options = {
				execPath: process.env.PORTABLE_EXECUTABLE_FILE,
			};
			app.relaunch(options);
		} else if (shim.isLinux() && linuxSafeRestart) {
			// this.showInfoMessageBox(_('The app is now going to close. Please relaunch it to complete the process.'));
			app.relaunch();
		} else {
			app.relaunch();
		}

		// app.exit();
		app.quit();
	}

laurent · 2023-11-12T11:45:12.927Z

Any chance you could create a PR with this?

LeoK987 · 2023-11-12T14:50:31.086Z

Any chance you could create a PR with this?

Seems not easy to do at the moment without messing up my existing repository. This will be together in my upcoming PR.

But in the moment if anyone wants to make the change, the included code is the only modification needed, unless you would also want to remove the linuxSafeRestart parameters, there would be a couple other small changes.

laurent · 2023-11-12T15:00:04.946Z

LeoK987:

Seems not easy to do at the moment without messing up my existing repository. This will be together in my upcoming PR.

Just to be clear, there can only be one feature or bug fix per pull request otherwise it's too difficult to review, manage reverts, etc. Please keep that in mind because as it is it seems we won't be able to merge any of your changes.

You may have to consider whether you're interested in collaborative work, or would simply prefer to create a new note taking app based on Joplin. Both options are fine, but of course the second option will have the consequences that we already discussed.

LeoK987 · 2023-11-12T17:26:19.742Z

I'm not making small changes, and as I said, it's not in a good shape yet for a merge request. This small modification is not among the main things I look to do, so it's not worth my effort to juggle my repositories to send a PR.

But if you think my changes won't be merged into Joplin, then I'll arrange related adjustments accordingly.

laurent · 2023-11-12T17:42:47.008Z

If your pull request is to add a single feature, for example support for local mds files, it will be merged.

However if there are many other unrelated changes, it will be a lot more difficult. If you have changes, such as the ones above, that are self-contained it might make sense to create a pull request, then we can merge it and you can rebase. That way you won't have to keep various minor changes in your branch.

system · 2024-11-06T17:42:53.585Z

This topic was automatically closed 360 days after the last reply. New replies are no longer allowed.