Coding Phase - Week 7 Report

bishoy · 2022-08-01T11:45:23.767Z

Goals Achieved

Added the feature to save the last change on the screen (main screen) when the plugin is closed.
Created email parser class and added the unit test for the email parser class.
I installed turndown and added 'joplin/turndown-plugin-gfm' plugin (convert HTML --> Markdown)
I extracted plain text with links from the HTML message.
Created the class responsible for posting notes to Joplin.

Next week

Add inline attachments to note.
Start by adding a feature that converts offline email messages into notes.
Make changes according to the feedback on my PR.

Demo

This demo shows the different export types of a note (HTML, Markdown, Text).

PackElend · 2022-08-01T12:03:54.183Z

bishoy:

Make changes according to the feedback on my PR.

can you mention them in your next report (and please continue using the link to the PR)?

could you setup some linter on your repo as indentation is inconsistent?
I think this is where having type annotations could help

I would like to see how it improved your PR. These kind of things happens quite often, so would be nice to have good before/after example.

PackElend · 2022-08-01T12:04:22.477Z

bishoy:

Added the feature to save the last change on the screen (main screen) when the plugin is closed.

is that due https://github.com/joplin/plugin-email/pull/4#issuecomment-1194563680?

bishoy · 2022-08-01T13:14:19.735Z

PackElend:

can you mention them in your next report (and please continue using the link to the PR)?

Sure

Before: the red lines
After: the Green Lines

PackElend:

could you setup some linter on your repo as indentation is inconsistent?

changes

PackElend:

I think this is where having type annotations could help

changes

bishoy · 2022-08-01T13:14:41.798Z

Not exactly,Although this problem that mentioned in this comment, I tested it on Linux and Windows and it works fine.but I will discuss this problem when I create a PR.

PackElend · 2022-08-01T14:26:51.658Z

bishoy:

Before: the red lines
After: the Green Lines

that is too much at once, it is about giving examples for lessons learned pure code is not helpful

bishoy · 2022-08-02T16:43:26.129Z

Okay, let's clarify more.

PackElend:

could you setup some linter on your repo as indentation is inconsistent?

linter helps the code be more readable, diagnose and fix technical issues, ...

Before:

import { Login } from "../model/message.model"

joplin.plugins.register({
[space]onStart: async function () {
		console.info('Email Plugin Started!');
		await app.init();
	},
});

After:

import {Login} from '../model/message.model';

joplin.plugins.register({
[tab]onStart: async function() {
        console.info('Email Plugin Started!');
        await app.init();
    },
});

PackElend:

I think this is where having type annotations could help

I used an annotated type void in the promise to annotate that the promise doesn't return any value when resolved.

Before:

return new Promise((resolve, reject) => {

After:

return new Promise<void>((resolve, reject) => {