BETA Markdown editor auto-indents within HTML <tags> and uses tabs. BLECH!

t0dd · 2024-03-22T19:23:09.909Z

Operating system

Linux

Joplin version

2.14.19

Desktop version info

Joplin 2.14.19 (prod, linux)

Client ID: 9959465eea794e60b1b95760c308ca91
Sync Version: 3
Profile Version: 46
Keychain Supported: No

Revision: 971c4e5

Backup: 1.4.1
Combine notes: 1.2.2
Conflict Resolution: 1.2.3
Favorites: 1.3.2
Folding in Code Mirror Editor: 2.0.1
Inline tags: 1.3.0
Inline TODO: 1.7.0
Note list (Preview): 0.4.1
Note overview: 1.7.1
Note Rename: 1.0.0
Note Tabs: 1.4.0
Quick Links: 1.3.2
Space Indenter: 0.2.2
Templates: 2.4.0

Editor

Markdown Editor

What issue do you have?

The markdown editor auto-indents when you do something like

<style>
    blah blah blah
</style>

I want that to stop. Even worse, it indents with a tab. I really want that to stop.

I kinda wish the Space Indenter plugin stepped in here and asserted its authority. Alas, it does not. I don't know if this is a Space Indenter bug or a markdown editor feature request.

In summary:

I don't want the markdown editor to auto-indent. Ever.
I don't want the markdown editor to use tabs when it does auto-indent. Ever.

So, is this a plugin ( @shikuz ) bug? Or a general feature request. Or both?

Thanks.
-t

P.S. The Space Indenter plugin has the option to strip all tabs and replace them with spaces upon note load. That's too brute-force for me because I do use tabs here and there on occasion. I just don't 99% of the time.

t0dd · 2024-03-22T19:43:07.902Z

FYI. My Space Indenter Plugin settings are thus:

Screenshot from 2024-03-22 15-41-26879×493 44.1 KB

muzak · 2024-03-22T21:23:14.325Z

Your settings work as intended on my machine. I can only reproduce the issue after disabling the plugin.

t0dd · 2024-03-22T21:33:42.276Z

Ah ha! I should also add that I have "Opted-in to the editor beta" in the General options (I updated the post's heading). If I turn it off, it does not have this behavior.

And so, this issue is a beta-editor issue, then. Or the plugin is not fully compliant with the beta editor? Dunno who should own this.

muzak · 2024-03-22T21:54:43.100Z

I think it's the latter. The beta editor has tab auto-indent as expected. The only plugin setting that's compliant with the beta editor is Automatic find & replace.

Off-topic: should Beta Editor: be added to About Joplin?

personalizedrefriger · 2024-03-22T23:38:29.480Z

I've opened a pull request on the Space Indenter plugin's GitHub repository that should resolve this:

github.com/alondmnt/joplin-plugin-space-indenter

Support the beta markdown editor

alondmnt:main ← personalizedrefrigerator:pr/support-cm6

opened 11:15PM - 22 Mar 24 UTC

personalizedrefrigerator

+289 -127

# Summary Adds support for the beta markdown editor. Specifically, this pu…ll request: 1. Updates the plugin build script to support importing CodeMirror 6 packages (the new build script is copied [from the plugin template](https://github.com/laurent22/joplin/blob/dev/packages/generator-joplin/generators/app/templates/webpack.config.js), [see the editor plugin tutorial](https://joplinapp.org/help/api/tutorials/cm6_plugin#update-the-plugin-build-script) for details). - Upgrading the build script also required upgrading the dependencies in `package.json` to newer versions. The new versions were taken from [the plugin template](https://github.com/laurent22/joplin/blob/dev/packages/generator-joplin/generators/app/templates/package_TEMPLATE.json). - Types in `api/` **were not updated.** 2. Splits the current `index.js` content script into two content scripts — one for CodeMirror 5 and one for CodeMirror 6. # Notes - The CodeMirror 5 plugin seems to include additional logic for indenting lists. This logic was not included in the CodeMirror 6 plugin. - This pull request also adds support for Joplin for Android — I've verified that this plugin 1) can be loaded in a custom build of Joplin 3.0.1 and 2) can be used to switch the "increase indent" button between adding spaces and adding tabs. # Testing This pull request has been tested manually by: 1. Enabling the beta editor 2. Creating an opening `<style>` tag 3. Pressing <kbd>enter</kbd> 4. Verifying that the new line is indented with spaces 5. Changing the indentation setting from spaces to tabs in settings 6. Repeating steps 2-3 and verifying that the new line is indented with tabs. 7. Disabling "smart indent" 8. Creating an opening `<style>` tag and pressing <kbd>enter</kbd> 9. Verifying that the new line is not indented. 10. Indenting by pressing <kbd>tab</kbd> 11. Pressing <kbd>enter</kbd> and verifying that the new line is indented to match the previous. 12. Changing "how many spaces should a block be indented" to 8 13. Creating a list and indenting an item by pressing <kbd>tab</kbd> 14. Verifying that the new item is indented with 2 tabs 15. Disabling tab indentation 16. Repeating step 13 and verifying that indentation uses 8 spaces Steps 2-11 were also tested in the legacy CodeMirror 5 editor. **Note**: The above testing was done on Ubuntu 22.04 with Joplin 2.14.20. I have also verified that the modified version of the plugin can be used to enable space indentation in Joplin 2.11.11 with default settings.

shikuz · 2024-03-23T03:50:30.808Z

Thanks so much @personalizedrefriger. The PR was merged and released as Space Indenter v0.2.3, which should become available shortly.

t0dd · 2024-03-25T17:17:04.453Z

Rock on! Glad I gave you that itch to scratch.

system · 2024-04-24T17:17:48.006Z

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.